Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update allow list settings access #38886

Merged
merged 11 commits into from
Aug 15, 2024
Merged

Update allow list settings access #38886

merged 11 commits into from
Aug 15, 2024

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Aug 14, 2024 •
edited
Loading

Fixes #

  • Updates the allow list logic so that the settings are accessible regardless of the state of the related security features.
  • Collapses Allow and Block lists in the Jetpack security settings when disabled or unpopulated.
  • General Protect UI adjustments as per design.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Checkout this branch for Protect and Jetpack on a fresh JN instance using the beta tester
  • Run through the various scenarios outlined in the screenshots below
  • Ensure the proposed fixes/updates apply
  • Ensure that no regressions are introduced

Screenshots

Jetpack block list enabled:
Screen Shot on 2024-08-14 at 15-01-36

Jetpack block list disabled:
Screen Shot on 2024-08-14 at 14-58-21

Jetpack block list disabled (list populated):
Screen Shot on 2024-08-14 at 15-02-14

Jetpack allow list enabled:
Screen Shot on 2024-08-14 at 15-35-46

Jetpack allow list disabled:
Screen Shot on 2024-08-14 at 15-36-17

Jetpack allow list disabled (list populated):
Screen Shot on 2024-08-14 at 15-36-56

Jetpack Allow list settings always accessible (when all sec features inactive):

  • Supported:
    Screen Shot on 2024-08-14 at 15-48-35
  • Unsupported:
    Screen Shot on 2024-08-14 at 15-49-42

Protect allow/block list enabled:
Screen Shot on 2024-08-14 at 15-53-28

Protect allow/block list disabled:
Screen Shot on 2024-08-14 at 15-54-22

Protect allow/block list disabled (list populated):
Screen Shot on 2024-08-14 at 15-54-58

Protect Allow list settings always accessible (when all sec features inactive):

  • Supported:
    Screen Shot on 2024-08-14 at 15-51-47
  • Unsupported:
    Screen Shot on 2024-08-14 at 15-50-55

General adjustment to Protect Firewall UI as per @ilonagl's proposal:
Screen Shot on 2024-08-14 at 16-46-55

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/allow-list-settings-access branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/allow-list-settings-access

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu labels Aug 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    A. Team Review: add the "[Status] Needs Team Review" label
    • For most changes, including minor cross-team impacts.
    • Example: Updating a team-specific component or a small change to a shared library.
      B. Crew Review: add the "[Status] Needs Review" label
    • For significant changes to core functionality.
    • Example: Major updates to a shared library or complex features.
      C. Both: Start with Team, then request Crew
    • For complex changes or when you need extra confidence.
    • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for September 3, 2024 (scheduled code freeze on September 2, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dkmyta dkmyta marked this pull request as ready for review August 14, 2024 22:58
@ilonagl
Copy link

ilonagl commented Aug 15, 2024

It looks great! Thanks for doing the changes so quickly. 👏

@ilonagl
Copy link

ilonagl commented Aug 15, 2024

I wonder if we could make the buttons bigger? Instead of the small ones (28px) use the default ones (40px) ones?

@dkmyta
Copy link
Contributor Author

dkmyta commented Aug 15, 2024 •
edited
Loading

I wonder if we could make the buttons bigger?

If you are referring to the secondary buttons for savings the IP lists and adding your own IP to the allow list, we use a smaller button to maintain consistency/unification with the Jetpack settings. All buttons within that security settings page, and throughout various settings in the core plugin use the small variant. Open to changing this approach of course if y'all agree, tagging in @nateweller for his opinion.

@nateweller nateweller added this to the protect/3.0.0 milestone Aug 15, 2024
nateweller
nateweller previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! We could follow up with some adjustments to the "save list" button sizes if we like. Since the buttons are only displayed when the lists are enabled, having them larger doesn't seem problematic to me or anything 👍

@nateweller nateweller added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] In Progress labels Aug 15, 2024
@nateweller nateweller merged commit bd112b6 into trunk Aug 15, 2024
57 checks passed
@nateweller nateweller deleted the update/allow-list-settings-access branch August 15, 2024 01:10
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 15, 2024
nateweller pushed a commit that referenced this pull request Aug 18, 2024
@dkmyta @nateweller
Update allow list settings access (#38886)
0be18fc
pkuliga pushed a commit that referenced this pull request Aug 23, 2024
@dkmyta @pkuliga
Update allow list settings access (#38886)
b5e1a31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateweller nateweller nateweller approved these changes

Assignees

@dkmyta dkmyta

Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF.
Projects
None yet
Milestone
protect/3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dkmyta @ilonagl @nateweller